Skip to content

feat(fracmanager): add handling for upload queue overflow and disk space exhaustion#266

Merged
eguguchkin merged 6 commits intomainfrom
265-handling-overflow
Mar 6, 2026
Merged

feat(fracmanager): add handling for upload queue overflow and disk space exhaustion#266
eguguchkin merged 6 commits intomainfrom
265-handling-overflow

Conversation

@eguguchkin
Copy link
Contributor

@eguguchkin eguguchkin commented Nov 18, 2025

Fixes #265

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

❌ PR Title Validation Failed
Please refer to CONTRIBUTING.md

@eguguchkin eguguchkin force-pushed the 265-handling-overflow branch from c82d18a to 4abfc8c Compare November 18, 2025 11:00
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

❌ PR Title Validation Failed
Please refer to CONTRIBUTING.md

@eguguchkin eguguchkin force-pushed the 156-new-lifecycle-manager branch 2 times, most recently from 3e082e3 to e956ab5 Compare November 18, 2025 16:12
@eguguchkin eguguchkin force-pushed the 265-handling-overflow branch from 4abfc8c to fe82714 Compare November 18, 2025 22:31
@eguguchkin eguguchkin changed the title feat(fracmanager) add handling for upload queue overflow and disk space exhaustion feat(fracmanager): add handling for upload queue overflow and disk space exhaustion Nov 18, 2025
@eguguchkin eguguchkin marked this pull request as draft November 18, 2025 22:31
@eguguchkin eguguchkin force-pushed the 156-new-lifecycle-manager branch from e956ab5 to 245b875 Compare November 19, 2025 08:42
@eguguchkin eguguchkin force-pushed the 265-handling-overflow branch from fe82714 to 9c8e96b Compare November 20, 2025 07:08
@eguguchkin eguguchkin marked this pull request as ready for review November 21, 2025 14:33
@eguguchkin eguguchkin force-pushed the 156-new-lifecycle-manager branch 3 times, most recently from 79ea9fe to 4054ad1 Compare January 16, 2026 15:08
Base automatically changed from 156-new-lifecycle-manager to main January 16, 2026 15:46
@eguguchkin eguguchkin requested review from dkharms and forshev January 19, 2026 09:50
@eguguchkin eguguchkin modified the milestones: v0.67.0, v0.66.0 Jan 19, 2026
@eguguchkin eguguchkin force-pushed the 265-handling-overflow branch from 9c8e96b to 266d02d Compare January 20, 2026 16:52
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/large-4 467eb3 081ef0
12982.01 MB/s 11380.53 MB/s 0.88 🔴
1262.00 ns/op 1440.00 ns/op 1.14 🔴
FindSequence_Random/small-4 467eb3 081ef0
5128.78 MB/s 4548.61 MB/s 0.89 🔴
49.91 ns/op 56.28 ns/op 1.13 🔴

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 41.52047% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.57%. Comparing base (ad03474) to head (4866644).

Files with missing lines Patch % Lines
fracmanager/fraction_registry.go 19.29% 43 Missing and 3 partials ⚠️
fracmanager/lifecycle_manager.go 29.78% 31 Missing and 2 partials ⚠️
fracmanager/tasks.go 65.51% 9 Missing and 1 partial ⚠️
cmd/seq-db/seq-db.go 0.00% 5 Missing ⚠️
fracmanager/proxy_frac.go 72.72% 2 Missing and 1 partial ⚠️
fracmanager/config.go 71.42% 1 Missing and 1 partial ⚠️
tests/setup/env.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   71.42%   71.57%   +0.14%     
==========================================
  Files         205      206       +1     
  Lines       14910    15057     +147     
==========================================
+ Hits        10650    10777     +127     
- Misses       3484     3494      +10     
- Partials      776      786      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin modified the milestones: v0.66.0, v0.67.0 Jan 22, 2026
forshev
forshev approved these changes Jan 27, 2026
View reviewed changes
dkharms
dkharms reviewed Jan 29, 2026
View reviewed changes
@moflotas moflotas removed this from the v0.67.0 milestone Feb 16, 2026
@eguguchkin eguguchkin added this to the v0.68.0 milestone Mar 2, 2026
@eguguchkin eguguchkin force-pushed the 265-handling-overflow branch from 95ee41b to 66dfbda Compare March 6, 2026 09:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=10000-4 ad0347 c3b53a
47818.00 ns/op 54310.00 ns/op 1.14 🔴
AggWide/size=1000-4 ad0347 c3b53a
4780.00 ns/op 5531.00 ns/op 1.16 🔴
AggWide/size=10000-4 ad0347 c3b53a
47541.00 ns/op 54711.00 ns/op 1.15 🔴

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=10000-4 ad0347 106b52
47818.00 ns/op 55523.00 ns/op 1.16 🔴
AggWide/size=1000-4 ad0347 106b52
4780.00 ns/op 5517.00 ns/op 1.15 🔴
AggWide/size=10000-4 ad0347 106b52
47541.00 ns/op 56052.00 ns/op 1.18 🔴

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=10000-4 ad0347 8f02f6
47818.00 ns/op 54019.00 ns/op 1.13 🔴
AggWide/size=10000-4 ad0347 8f02f6
47541.00 ns/op 54070.00 ns/op 1.14 🔴
FindSequence_Random/medium-4 ad0347 8f02f6
12292.95 MB/s 9846.13 MB/s 0.80 🔴
86.31 ns/op 104.00 ns/op 1.20 🔴

@eguguchkin eguguchkin merged commit 03387c3 into main Mar 6, 2026
8 checks passed
@eguguchkin eguguchkin deleted the 265-handling-overflow branch March 6, 2026 13:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=1000-4 ad0347 4ce7f5
4737.00 ns/op 5502.00 ns/op 1.16 🔴
FindSequence_Random/medium-4 ad0347 4ce7f5
12292.95 MB/s 10541.43 MB/s 0.86 🔴
86.31 ns/op 97.14 ns/op 1.13 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forshev forshev forshev approved these changes

@dkharms dkharms dkharms approved these changes

Assignees

No one assigned

Labels

epic/fracmanager-v2

Projects

None yet

Milestone

v0.68.0

Development

Successfully merging this pull request may close these issues.

Add handling for upload queue overflow and disk space exhaustion

5 participants

@eguguchkin @codecov-commenter @forshev @dkharms @moflotas